New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] improve regex matching in onnx-importer name sanitization #3955

Merged

zjgarvey merged 1 commit into llvm:main from zjgarvey:importer_sanitize_names_fix

Jan 14, 2025

Collaborator

zjgarvey commented Jan 13, 2025

Instead of adding unsupported characters on a case-by-case basis, we should replace anything that isn't alphanumeric, _, or ..


          improve regex matching in onnx importer name sanitization

014e7b8

zjgarvey requested a review from jinchen62

January 13, 2025 21:14

jinchen62 approved these changes

View reviewed changes

Collaborator

jinchen62 left a comment

LGTM, thanks!

zjgarvey merged commit 62eb38b into llvm:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet