-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): upgrade http/https/socks proxy agents #5548
chore(deps): upgrade http/https/socks proxy agents #5548
Conversation
d6c772d
to
315f638
Compare
Either this or the pinky-promise that you have tested both proxys still work:
I'd like to pull this to v2 as a "feature". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed the base to be v2.
There are now a two merge conflicts, could you fix them? ^^
315f638
to
f7f9981
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
This fixes a bug where a monitor using a HTTPS proxy server which is configured with a cert that uses a newer root cert (e.g. LetsEncrypt) would throw an error saying
self-signed certificate
but it's actually valid. Checking the https proxy manually in any browser works + using any ssl checker tool also verifies that the cert is valid. Currently the only way to get the http check to pass is to enable theIgnore TLS/SSL error for HTTPS websites
checkbox.Upgrading the
https-proxy-agent
package fixes this issue. Since the HttpsProxyAgent syntax changed slightly (requiring a proxy url string instead of proxyOptions to be fed in), I've also gone ahead and upgradedhttp-proxy-agent
andsocks-proxy-agent
so that all proxy options use the same syntax now.I can provide a test https proxy that causes monitor checks to fail on the latest version of uptime-kuma but works with this fix, just lmk and I'll get you a temp user/pass combo for this PR.
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.