Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge generator for status pages #5572

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

hiagodotme
Copy link

@hiagodotme hiagodotme commented Jan 25, 2025

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

I implemented a new feature to generate statusPage badges as discussed in issue #5507

Type of change

Please delete any options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

01_button_generator

02_generator_form

  1. Badge style to be generated
  2. Texts for each situation, it is better to let each user choose their text as it may be used in different places and they may prefer to change the terms.
  3. Image preview (in current page status)

@louislam @CommanderStorm 🚀

@cyril59310
Copy link
Contributor

You cannot edit other language file. Only the en.json file can be modified to avoid conflicts with the Weblate translation tool.

see the contribution guide: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#translations

@hiagodotme
Copy link
Author

Você não pode editar outro arquivo de idioma. Somente o en.jsonarquivo pode ser modificado para evitar conflitos com a ferramenta de tradução Weblate.

veja o guia de contribuição: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#translations

@cyril59310 I translated pt-BR.json because it is my native language, I misinterpreted this part of the guide line.

Is it possible to revert this by maintaining this pull request?

@hiagodotme
Copy link
Author

hiagodotme commented Jan 25, 2025

@cyril59310 I reverted the pt-BR.json file to the last authorized commit on master using the command below.

But now I believe it is following all the guidelines.

git checkout 489b73a7a638b6bc248e79800257808a19b15253 -- src/lang/pt-BR.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants