[RACL] Parse mappings and auto-connect RACL #25749

Razer6 · 2024-12-25T09:20:14Z

This PR adds support for parsing the RACL config. In the first place, a *-connection is implemented, mapping all registers to a single RACL policy. The RACL policies are distributed to subscribing IPs. A selection vector in the form of a parameter selects the right policy from the policy vector.

RACL is applied to PWM first.

rswarbrick

A partial review so far, sorry (just the first two commits)

util/raclgen/lib.py

util/topgen.py

util/topgen/intermodule.py

util/topgen/merge.py

hw/ip/pwm/rtl/pwm_reg_top.sv

hw/ip/pwm/lint/pwm.vbl

hw/ip/pwm/rtl/pwm.sv

hw/ip/pwm/data/pwm.hjson

matutem · 2025-01-22T15:04:11Z

util/topgen/merge.py

+        if instance.get('racl_mappings') is not None:
+            raise ValueError("Cannot specify both 'racl_mapping' and 'racl_mappings'")
+        del instance['racl_mapping']
+        instance['racl_mappings'] = {None: racl_mapping}


A dictionary with "None" as a key can be confusing. Is there a better name for this, like "default" or some such.

It can but this would add an assumption on how a TLUL interface can be named / or not. I think this one was done in the same way as for the base address. I am happy to change that in a follow up PR.

I hope you consider adding a default racl object in the top config, and when an IP doesn't assign one we give it the default. This has no name clash issues. Okay in a subsequent PR.

We agreed on core being the default.

util/topgen/templates/toplevel_racl_pkg.sv.tpl

rswarbrick

I've just worked through this again and I'm pretty convinced! I know that there are a couple of pending items from @matutem, but I'm very happy when we're ready with them.

Signed-off-by: Robert Schilling <rschilling@rivosinc.com>

matutem

LGTM, but there are items that can be addressed in subsequent PRs.

vogelpi · 2025-01-23T22:22:39Z

CHANGE AUTHORIZED: hw/ip/i2c/data/i2c.hjson
CHANGE AUTHORIZED: hw/ip/i2c/rtl/i2c.sv
CHANGE AUTHORIZED: hw/ip/i2c/rtl/i2c_reg_top.sv
CHANGE AUTHORIZED: hw/ip/pwm/data/pwm.hjson
CHANGE AUTHORIZED: hw/ip/pwm/rtl/pwm.sv
CHANGE AUTHORIZED: hw/ip/pwm/rtl/pwm_reg_top.sv
CHANGE AUTHORIZED: hw/ip/tlul/rtl/tlul_adapter_reg_racl.sv
CHANGE AUTHORIZED: hw/ip/uart/data/uart.hjson
CHANGE AUTHORIZED: hw/ip/uart/rtl/uart.sv
CHANGE AUTHORIZED: hw/ip/uart/rtl/uart_reg_top.sv
CHANGE AUTHORIZED: hw/top_earlgrey/rtl/autogen/top_earlgrey.sv

This PR changes hardware blocks used in Earlgrey as well as Earlgrey but the functionality doesn't change as RACL is still disabled in Earlgrey, i.e., these changes have no functional impact.

matutem · 2025-01-23T23:57:21Z

CHANGE AUTHORIZED: hw/ip/i2c/data/i2c.hjson
CHANGE AUTHORIZED: hw/ip/i2c/rtl/i2c.sv
CHANGE AUTHORIZED: hw/ip/i2c/rtl/i2c_reg_top.sv
CHANGE AUTHORIZED: hw/ip/pwm/data/pwm.hjson
CHANGE AUTHORIZED: hw/ip/pwm/rtl/pwm.sv
CHANGE AUTHORIZED: hw/ip/pwm/rtl/pwm_reg_top.sv
CHANGE AUTHORIZED: hw/ip/tlul/rtl/tlul_adapter_reg_racl.sv
CHANGE AUTHORIZED: hw/ip/uart/data/uart.hjson
CHANGE AUTHORIZED: hw/ip/uart/rtl/uart.sv
CHANGE AUTHORIZED: hw/ip/uart/rtl/uart_reg_top.sv
CHANGE AUTHORIZED: hw/top_earlgrey/rtl/autogen/top_earlgrey.sv

hw/ip/i2c/rtl/i2c.sv

hw/ip/tlul/rtl/tlul_adapter_reg_racl.sv

Razer6 force-pushed the racl-connections branch 9 times, most recently from 6b1e47c to 2f84455 Compare December 28, 2024 19:14

Razer6 marked this pull request as ready for review December 29, 2024 16:13

Razer6 requested a review from msfschaffner as a code owner December 29, 2024 16:13

Razer6 assigned rswarbrick, andreaskurth and vogelpi Dec 29, 2024

Razer6 requested review from rswarbrick, andreaskurth and vogelpi December 29, 2024 16:13

Razer6 unassigned rswarbrick, andreaskurth and vogelpi Dec 29, 2024

Razer6 removed the request for review from msfschaffner December 29, 2024 16:14

rswarbrick reviewed Dec 30, 2024

View reviewed changes

hw/ip/pwm/rtl/pwm_reg_top.sv Outdated Show resolved Hide resolved

hw/ip/pwm/lint/pwm.vbl Outdated Show resolved Hide resolved

hw/ip/pwm/rtl/pwm.sv Outdated Show resolved Hide resolved

hw/ip/pwm/data/pwm.hjson Outdated Show resolved Hide resolved

Razer6 force-pushed the racl-connections branch 7 times, most recently from f73b4bf to 26c496d Compare January 1, 2025 12:14

matutem reviewed Jan 22, 2025

View reviewed changes

util/topgen/templates/toplevel_racl_pkg.sv.tpl Outdated Show resolved Hide resolved

Razer6 force-pushed the racl-connections branch 5 times, most recently from d0c41f5 to af93c02 Compare January 23, 2025 08:17

Razer6 mentioned this pull request Jan 23, 2025

[RACL] Instantiate RACL for Darjeeling #25986

Merged

rswarbrick approved these changes Jan 23, 2025

View reviewed changes

matutem self-requested a review January 23, 2025 17:07

Razer6 added 12 commits January 23, 2025 19:00

[hw,racl_ctrl,rtl] Rename policy vector and add intermodule sigs

b1df206

Signed-off-by: Robert Schilling <rschilling@rivosinc.com>

[RACL] Implement mapping parsing and autoconnect

7bdd229

Signed-off-by: Robert Schilling <rschilling@rivosinc.com>

[hw,pwm,racl] Add RACL support to PWM

cb9423a

Signed-off-by: Robert Schilling <rschilling@rivosinc.com>

[hw,uart,racl] Add RACL support to UART

ca9298f

Signed-off-by: Robert Schilling <rschilling@rivosinc.com>

[hw,i2c,racl] Add RACL support to I2C

dea6de8

Signed-off-by: Robert Schilling <rschilling@rivosinc.com>

[racl] Static ROT_PRIVATE protection of racl_ctrl

2e2e214

Signed-off-by: Robert Schilling <rschilling@rivosinc.com>

[hw,tlul_adapter_reg_racl,rtl] Add RACL protected tlul_adapter_reg

c3ed98b

Signed-off-by: Robert Schilling <rschilling@rivosinc.com>

[racl,ac_ranges] Add RACL support to AC Ranges

56ecd61

Signed-off-by: Robert Schilling <rschilling@rivosinc.com>

[hw,rv_plic,racl] Add RACL support to RV_PLIC

672c3bc

Signed-off-by: Robert Schilling <rschilling@rivosinc.com>

[hw,alert_handler,racl] Add RACL support to alert handler

11b944f

Signed-off-by: Robert Schilling <rschilling@rivosinc.com>

[racl] Ensure that default policy values have the right type

c047598

Signed-off-by: Robert Schilling <rschilling@rivosinc.com>

[racl] Define RACL and CTN UID bits from HJSON

14ac869

Signed-off-by: Robert Schilling <rschilling@rivosinc.com>

Razer6 force-pushed the racl-connections branch from af93c02 to 14ac869 Compare January 23, 2025 18:01

matutem approved these changes Jan 23, 2025

View reviewed changes

vogelpi reviewed Jan 24, 2025

View reviewed changes

hw/ip/i2c/rtl/i2c.sv Show resolved Hide resolved

vogelpi reviewed Jan 24, 2025

View reviewed changes

hw/ip/tlul/rtl/tlul_adapter_reg_racl.sv Show resolved Hide resolved

vogelpi merged commit c71c4ff into lowRISC:master Jan 24, 2025
38 checks passed

Razer6 deleted the racl-connections branch January 24, 2025 09:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RACL] Parse mappings and auto-connect RACL #25749

[RACL] Parse mappings and auto-connect RACL #25749

Razer6 commented Dec 25, 2024 •

edited

Loading

rswarbrick left a comment

matutem Jan 22, 2025

Razer6 Jan 22, 2025

matutem Jan 23, 2025 •

edited

Loading

Razer6 Jan 23, 2025

rswarbrick left a comment

matutem left a comment

vogelpi commented Jan 23, 2025

matutem commented Jan 23, 2025

[RACL] Parse mappings and auto-connect RACL #25749

[RACL] Parse mappings and auto-connect RACL #25749

Conversation

Razer6 commented Dec 25, 2024 • edited Loading

rswarbrick left a comment

Choose a reason for hiding this comment

matutem Jan 22, 2025

Choose a reason for hiding this comment

Razer6 Jan 22, 2025

Choose a reason for hiding this comment

matutem Jan 23, 2025 • edited Loading

Choose a reason for hiding this comment

Razer6 Jan 23, 2025

Choose a reason for hiding this comment

rswarbrick left a comment

Choose a reason for hiding this comment

matutem left a comment

Choose a reason for hiding this comment

vogelpi commented Jan 23, 2025

matutem commented Jan 23, 2025

Razer6 commented Dec 25, 2024 •

edited

Loading

matutem Jan 23, 2025 •

edited

Loading