Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gpio straps stress all #25974

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Gpio straps stress all #25974

wants to merge 1 commit into from

Conversation

marcelocarvalhoLowRisc
Copy link

@marcelocarvalhoLowRisc marcelocarvalhoLowRisc commented Jan 22, 2025 •
edited
Loading

Included the new straps testcase into the gpio_stress_all list of tests, to have more iterations and randomisation cases.
Merge the PR #25868 first.

@marcelocarvalhoLowRisc marcelocarvalhoLowRisc requested a review from a team as a code owner January 22, 2025 14:38
@marcelocarvalhoLowRisc marcelocarvalhoLowRisc requested review from rswarbrick and removed request for a team January 22, 2025 14:38
@marcelocarvalhoLowRisc marcelocarvalhoLowRisc force-pushed the gpio_straps_stress_all branch 5 times, most recently from 2215044 to 87583b4 Compare January 22, 2025 17:22
rswarbrick
rswarbrick reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this need to depend on #25868? I think you need to rebase this branch on top of that one and then add a note to the PR comment that says something "Merge the other PR first. Once that's merged, only the final commit will remain".

@marcelocarvalhoLowRisc
Copy link
Author

Doesn't this need to depend on #25868? I think you need to rebase this branch on top of that one and then add a note to the PR comment that says something "Merge the other PR first. Once that's merged, only the final commit will remain".

Yes, you are correct.

@marcelocarvalhoLowRisc marcelocarvalhoLowRisc force-pushed the gpio_straps_stress_all branch 2 times, most recently from 941d8d5 to 5af7d23 Compare February 3, 2025 10:35
@marcelocarvalhoLowRisc
Copy link
Author

Doesn't this need to depend on #25868? I think you need to rebase this branch on top of that one and then add a note to the PR comment that says something "Merge the other PR first. Once that's merged, only the final commit will remain".

Yes, you are correct.

I squashed the first PR about the straps. Or should I drop the changes and only keep the stress_all updates?

@marcelocarvalhoLowRisc
Included the gpio_straps_vseq in the gpio_stress_all_vseq list
587efb9 
Merge the PR lowRISC#25868 first.

Signed-off-by: Marcelo Carvalho Faleiro de Almeida <marcelo.carvalho@lowrisc.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rswarbrick rswarbrick rswarbrick left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcelocarvalhoLowRisc @rswarbrick