Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opentitantool] Eliminate use of min_specialization #25993

Merged
merged 2 commits into from
Jan 28, 2025
Merged

[opentitantool] Eliminate use of min_specialization #25993

merged 2 commits into from
Jan 28, 2025

Conversation

cfrantz
Copy link
Contributor

@cfrantz cfrantz commented Jan 23, 2025

Update serde_annotate to 0.0.12 and change all uses of dyn Annotate to dyn erased_serde::Serialize.

@cfrantz cfrantz requested a review from a team as a code owner January 23, 2025 21:25
@cfrantz cfrantz removed the request for review from a team January 23, 2025 21:25
@cfrantz
Copy link
Contributor Author

cfrantz commented Jan 23, 2025

This is a mechanical change made mostly with sed:

find . -name "*.rs" | xargs sed -i -e "s/Box<dyn Annotate>/Box<dyn erased_serde::Serialize>/g"

The latest version of serde_annotate does not require min_specialization and will allow us to stop depending on rust nightly.

@cfrantz
[rust] Add inventory crate
31d6464 
Signed-off-by: Chris Frantz <cfrantz@google.com>
@cfrantz
[opentitantool] Eliminate use of min_specialization
1316a36 
Update serde_annotate to 0.0.12 and change all uses of `dyn Annotate`
to `dyn erased_serde::Serialize`.

Signed-off-by: Chris Frantz <cfrantz@google.com>
@cfrantz cfrantz merged commit 7a97f66 into lowRISC:earlgrey_1.0.0 Jan 28, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothytrippel timothytrippel timothytrippel approved these changes

@moidx moidx moidx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cfrantz @moidx @timothytrippel