[ujson,perso_tlv,dice] Manual cherry-pick of #25958 #26093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a signed integer (int64_t) to store the parsed integer value could lead to an undefined behavior when parsing large numbers due to signed integer overflow. To address this issue, the parsed value is now stored in an unsigned integer (uint64_t). The updated implementation also includes a check to ensure that the parsed value can be safely converted back to a signed integer before copying it into the `result`. Signed-off-by: Anthony Chen <antchen@google.com> (cherry picked from commit 67b2fe4)
This adds buffer size checks in `perso_tlv_data.c` to prevent potential memory access vulnerabilities. Signed-off-by: Anthony Chen <antchen@google.com> (cherry picked from commit 78f1dc3)
This removes the unused `cert_size` output parameter in the `dice_cert_check_valid` function. Also, the original implementation caused a clang compiler error due to incompatible pointer types by passing `&cert_size` (size_t *) to the `cert_x509_asn1_check_serial_number` function (expects a uint32_t * type). Signed-off-by: Anthony Chen <antchen@google.com> (cherry picked from commit 58e6fca)
anthonychen1251
requested review from
jadephilipoom
and removed request for
a team
|
An automatic cherry-pick is created in #26104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #25958