Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for whether a string is in another string #32

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tjk
Copy link

@tjk tjk commented Jul 10, 2015

Hey there!

I'll squash and rebase after some feedback.

  1. could you please let me know if you are interested in this feature?
  2. am I missing something when it comes to the current state of the .gitignore?
  3. I put this patch together quickly and could have missed something obvious...
  4. I'll be testing this shortly, but wanted to just get this up ASAP.
  5. my vim config automatically changes some whitespace -- let me know if you want me to do undo those changes, please.
  6. I just noticed in the other PR there are unit tests somewhere... didn't notice them in quick glance + should I update example directory?

Thanks for any comments!

@lpabon
Copy link
Owner

lpabon commented Jul 19, 2015

Hi @tjk , I'll make some time this week to review it. Thank you for the patch.

@lpabon
Copy link
Owner

lpabon commented Oct 14, 2015

@tjk Sorry, it has taken me so long to review this. I just finished my latest project Heketi. I'm reviewing now

*.sublime-*

# some build artifacts... why aren't these ignored?
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I'm not sure. Thank you for setting this up

@lpabon
Copy link
Owner

lpabon commented Oct 14, 2015

@tjk Just reviewed your code. I really, really like this. Please let me know if you have time to add unit tests since it has been a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants