add transit arrival/departure times #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielwhogan Thanks for creating a PR! We will take a look at this shortly :) |
sarahsnow1
approved these changes
Jun 8, 2017
There was a problem hiding this comment.
Thanks for the PR. I will merge this after #816 gets completed.
| if (transitInstruction == null) { | ||
| var turnInstruction = instruction.getHumanTurnInstruction() | ||
| val pattern = Pattern.compile("\\([0-9]+ stops\\)") | ||
| val matcher = pattern.matcher(turnInstruction) | ||
| turnInstruction = matcher.replaceAll("") | ||
| val transitStops = instruction.getTransitInfo()?.getTransitStops() as ArrayList<TransitStop> | ||
| val departureTime = transitStops[0].getDepartureDateTime().substring(11, 16) |
There was a problem hiding this comment.
Created a ticket here to convert these TransitStop properties to Date objects which will make interaction with this property more safe
There was a problem hiding this comment.
I'll switch to a Date object once this issue is resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added arrival/departure times to the multimodal transit view. Fixes #699