Update to Unicode v16.0.0 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiasbynens
changed the title
|
I recall that I manually paste the emoji results into the fixtures and it was not very smooth. Yes, a "rebaseline test fixtures" script will definitely help the situation.
|
JLHwung
force-pushed
the
unicode-16.0.0
branch
from
2cc144a to
1571fa5
Compare
JLHwung
reviewed
Sep 17, 2024
| @@ -2,10 +2,25 @@ const TRANSFORM_U = { unicodeFlag: 'transform', unicodeSetsFlag: 'transform' }; | |||
|
|
|||
| const Basic_Emoji = { | |||
| get all() { return `${this.strings}|[${this.chars}]` }, | |||
| // node -e "process.stdout.write(require('regenerate-unicode-properties/Property_of_Strings/Basic_Emoji').strings.sort((a,b)=>b.length-a.length).join('|'))" | |||
There was a problem hiding this comment.
Provided node oneliners to update the test fixtures. Personally I piped the result to pbcopy and paste directly in the IDE. At least we can do it semi-manually.
We also restructured the RGI_Emoji tests so that we can easily update the result every year.
JLHwung
changed the title
|
@mathiasbynens This PR is ready to review now. |
Merged
JLHwung
approved these changes
Sep 18, 2024
|
Thanks @JLHwung! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/fixturesmust be rebaselined before this can be merged.@JLHwung Do you remember how you did this for #84? Maybe we should check in a “rebaseline test fixtures” script to more easily update expectations as part of future Unicode updates.