Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure git to use ssh rather than unsupported git:// protocol #31

Merged
merged 4 commits into from
Sep 21, 2022

Conversation

mickmister
Copy link
Contributor

Summary

As an alternative to #30, this PR makes it so git is configured in a way that sidesteps this issue npm/cli#4896.

Ticket Link

@mickmister mickmister requested a review from levb August 18, 2022 17:11
@mickmister
Copy link
Contributor Author

@hanzei Please a look at this as well. A few months ago, plugin CI got much slower due to fetching npm dependencies from GitHub being very slow. The fix in this PR changes the protocol to sidestep the issue npm/cli#4896. With this fix in the Jira plugin, it made CI go from 34 minutes to 8 minutes.

@mickmister mickmister requested a review from hanzei September 15, 2022 04:20
@mickmister
Copy link
Contributor Author

@hanzei I'd like to get this and #32 merged to fix a lot of the CI-related issues with plugins. Plugins will now be able to be compiled with Go 1.18, and will work with any node version.

Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

plugin-ci/orb.yml Outdated Show resolved Hide resolved
@mickmister mickmister merged commit df3e94b into master Sep 21, 2022
@mickmister mickmister deleted the git-instead-of branch September 21, 2022 03:58
@hanzei hanzei added the 3: Reviews Complete All reviewers have approved the pull request label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants