Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-28933 Customize taskbar icon depends to session #2899

Merged
merged 4 commits into from
Dec 5, 2023
Merged

MM-28933 Customize taskbar icon depends to session #2899

merged 4 commits into from
Dec 5, 2023

Conversation

hasancankucuk
Copy link
Contributor

Summary

Ticket Link

Fixes: mattermost/mattermost#24618
Ticket: https://mattermost.atlassian.net/browse/MM-28933

Checklist

Device Information

This PR was tested on: MacOS 14.0 & Windows 11

Screenshots

Ekran Resmi 2023-11-02 00 52 40

Release Note

@mattermost-build
Copy link
Contributor

Hello @hasancankucuk,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@devinbinnie devinbinnie added the 2: Dev Review Requires review by a core committer label Nov 2, 2023
@devinbinnie devinbinnie added the 1: UX Review Requires review by a UX Designer label Nov 2, 2023
M-ZubairAhmed
M-ZubairAhmed approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@M-ZubairAhmed M-ZubairAhmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix

@devinbinnie
Copy link
Member

/update-branch

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@devinbinnie devinbinnie added Build Apps for PR Builds signed builds for testing and removed Lifecycle/1:stale labels Nov 13, 2023
@mattermost-build
Copy link
Contributor

Building app in separate branch.

@mattermost-build mattermost-build removed the Build Apps for PR Builds signed builds for testing label Nov 13, 2023
@devinbinnie
Copy link
Member

@abhijit-singh I've started the build for this PR, can you have a look to make sure everything matches once it's built? Let me know if you need help with it :)

@devinbinnie
Copy link
Member

@abhijit-singh Gentle ping :)

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@devinbinnie
Copy link
Member

@abhijit-singh Can you have a look here?

@abhijit-singh abhijit-singh added the Build Apps for PR Builds signed builds for testing label Dec 1, 2023
@mattermost-build
Copy link
Contributor

Building app in separate branch.

@mattermost-build mattermost-build removed the Build Apps for PR Builds signed builds for testing label Dec 1, 2023
@abhijit-singh
Copy link

@devinbinnie Yep checking now, is your PR with the fix for the session expired check merged?

@devinbinnie
Copy link
Member

/update-branch

@devinbinnie devinbinnie added the Build Apps for PR Builds signed builds for testing label Dec 1, 2023
@mattermost-build
Copy link
Contributor

Building app in separate branch.

@mattermost-build mattermost-build removed the Build Apps for PR Builds signed builds for testing label Dec 1, 2023
@devinbinnie
Copy link
Member

@abhijit-singh Should be merged now, job is running to build the apps: https://github.com/mattermost/desktop/actions/runs/7061608654?pr=2899

abhijit-singh
abhijit-singh approved these changes Dec 4, 2023
View reviewed changes
Copy link

@abhijit-singh abhijit-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @hasancankucuk and @devinbinnie!

@devinbinnie
Copy link
Member

/update-branch

@devinbinnie devinbinnie removed the 1: UX Review Requires review by a UX Designer label Dec 5, 2023
devinbinnie
devinbinnie approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@devinbinnie devinbinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @hasancankucuk!

@devinbinnie devinbinnie merged commit 9f80b7d into mattermost:master Dec 5, 2023
7 checks passed
@amyblais amyblais added this to the v5.7.0 milestone Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinbinnie devinbinnie devinbinnie approved these changes

@M-ZubairAhmed M-ZubairAhmed M-ZubairAhmed approved these changes

@abhijit-singh abhijit-singh abhijit-singh approved these changes

Assignees
No one assigned
Labels
2: Dev Review Requires review by a core committer Contributor release-note
Projects
None yet
Milestone
v5.7.0
Development

Successfully merging this pull request may close these issues.

Desktop: customize the taskbar icon when sessions are expired
7 participants
@hasancankucuk @mattermost-build @devinbinnie @abhijit-singh @M-ZubairAhmed @amyblais @mm-cloud-bot