Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-55466] Update to node-gyp v10 to fix Python script error #2909

Merged
merged 1 commit into from
Nov 13, 2023
Merged

[MM-55466] Update to node-gyp v10 to fix Python script error #2909

merged 1 commit into from
Nov 13, 2023

Conversation

devinbinnie
Copy link
Member

Summary

Update node-gyp to v10 to patch this issue in CI: nodejs/node-gyp#2869

Ticket Link

https://mattermost.atlassian.net/browse/MM-55466

NONE

@devinbinnie devinbinnie added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Nov 13, 2023
@devinbinnie devinbinnie added this to the v5.6.0 milestone Nov 13, 2023
@devinbinnie devinbinnie merged commit 5ae7f66 into mattermost:master Nov 13, 2023
13 checks passed
@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit that referenced this pull request Nov 13, 2023
@devinbinnie @mattermost-build
[MM-55466] Update to node-gyp v10 to fix Python script error (#2909)
f91f030 
(cherry picked from commit 5ae7f66)
@mattermost-build mattermost-build mentioned this pull request Nov 13, 2023
Merged
@mattermost-build mattermost-build added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Nov 13, 2023
devinbinnie added a commit that referenced this pull request Nov 13, 2023
@mattermost-build @devinbinnie
[MM-55466] Update to node-gyp v10 to fix Python script error (#2909) (#…
e34fac7 
…2910)

(cherry picked from commit 5ae7f66)

Co-authored-by: Devin Binnie <52460000+devinbinnie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone release-note-none
Projects
None yet
Milestone
v5.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@devinbinnie @mattermost-build @mm-cloud-bot