Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NOTICE.txt #2912

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Update NOTICE.txt #2912

merged 1 commit into from
Nov 14, 2023

Conversation

amyblais
Copy link
Member

@amyblais amyblais commented Nov 13, 2023 •
edited
Loading 

 - Added electron-extension-installer and node-gyp to https://github.com/mattermost/desktop.

@mm-cloud-bot
Copy link

@amyblais: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@amyblais amyblais added 2: Dev Review Requires review by a core committer CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Nov 13, 2023
@amyblais amyblais added this to the v5.6.0 milestone Nov 13, 2023
@amyblais amyblais requested a review from devinbinnie November 13, 2023 20:05
@amyblais amyblais added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 14, 2023
@devinbinnie devinbinnie merged commit 61bc359 into master Nov 14, 2023
28 checks passed
@devinbinnie devinbinnie deleted the amyblais-patch-3 branch November 14, 2023 17:17
@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

@amyblais
Copy link
Member Author

I don't have merge permissions. Would you be able to help merge this Devin?

mattermost-build pushed a commit that referenced this pull request Nov 14, 2023
@amyblais @mattermost-build
Update NOTICE.txt (#2912)
9cf1fd9 
Updates based on https://github.com/mattermost/desktop/blob/master/package.json

(cherry picked from commit 61bc359)
@mattermost-build mattermost-build mentioned this pull request Nov 14, 2023
Merged
@mattermost-build mattermost-build added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Nov 14, 2023
devinbinnie pushed a commit that referenced this pull request Nov 14, 2023
@mattermost-build @amyblais
Update NOTICE.txt (#2912) (#2913)
4a4a109 
Updates based on https://github.com/mattermost/desktop/blob/master/package.json

(cherry picked from commit 61bc359)

Co-authored-by: Amy Blais <29708087+amyblais@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinbinnie devinbinnie devinbinnie approved these changes

Assignees

@devinbinnie devinbinnie

Labels
4: Reviews Complete All reviewers have approved the pull request CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone release-note
Projects
None yet
Milestone
v5.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@amyblais @mm-cloud-bot @mattermost-build @devinbinnie