[MM-22555] Auto-fill server URLs when deep linking into the Desktop App and the server isn't configured #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinbinnie
requested review from
a team and
agarciamontoro
and removed request for
a team
devinbinnie
requested review from
a team and
harshilsharma63
and removed request for
a team
|
This could probably use an E2E test, but I want to make sure #3201 is merged first, as deeplinking from cold is broken without that fix. |
harshilsharma63
approved these changes
Nov 13, 2024
agarciamontoro
approved these changes
Nov 18, 2024
devinbinnie
added
3: QA Review
|
@yasserfaraazkhan Adding in case you want to take a peek now, but feel free to defer. |
yasserfaraazkhan
approved these changes
Nov 18, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR add a quality-of-life change to the Desktop App, where now users are able to click on deep links for server they do not have configured in the app, and have the app automatically pre-fill the Add Server modal (or Welcome Screen) for them with the server information. From there, the user can simply click Connect.
On top of this, permalinks will be automatically redirected to under this flow, so you can get to the message you want to see quicker.
Done for 2024 November Hackathon.
Ticket Link
https://mattermost.atlassian.net/browse/MM-22555