MAVLink Inspector, show all selected fields in the chart #12342
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -108,7 +108,7 @@ void QGCMAVLinkMessage::update(const mavlink_message_t &message) | |||
| _count++; | |||
| _message = message; | |||
|
|
|||
| if (_selected) { | |||
| if (_selected || _fieldSelected) { | |||
There was a problem hiding this comment.
Hmm, interesting. Shouldn't this just be _fieldSelected? Since the message might be selected but that doesn't mean that a field is selected. Otherwise you end up doing a bunch of work in updateField every time you select a new top level message. Or am I reading the code wrong?
There was a problem hiding this comment.
You're right, _selected is not needed. It's not a big overhead though because there's only one message selected at the time.
Do you want me to remove _selected from the if statement?
There was a problem hiding this comment.
Yes, you should remove it. Make the code clearer to others looking at it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, if I select
ATTITUDE.roll, the data is displayed on the chart. However, if I switch to another message (e.g.,RAW_IMU), theATTITUDE.rolldata stops rendering. It would be more intuitive if all selected fields (even from different messages) were shown on the chart simultaneously.For example, I want to investigate the correlation between
ATTITUDE.rollandRAW_IMU.xacc.I investigated why this approach was implemented and couldn't find a specific reason preventing us from displaying multiple fields from different messages simultaneously.
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.