forked from ARMmbed/mbed-os
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to the EMAC test #429
Open
multiplemonomials
wants to merge
12
commits into
dev/emac-mem-manager-improvements
Choose a base branch
from
dev/emac-test-improvements
base: dev/emac-mem-manager-improvements
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improvements to the EMAC test #429
multiplemonomials
wants to merge
12
commits into
dev/emac-mem-manager-improvements
from
dev/emac-test-improvements
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connectivity/netsocket/tests/TESTS/network/emac/emac_test_unicast_long.cpp
Show resolved
Hide resolved
JojoS62
approved these changes
Jan 24, 2025
multiplemonomials
force-pushed
the
dev/emac-mem-manager-improvements
branch
from
January 26, 2025 22:05
6b06a72
to
2cf8902
Compare
multiplemonomials
force-pushed
the
dev/emac-test-improvements
branch
from
January 26, 2025 23:19
21744e4
to
75e4ec6
Compare
Ran the new EMAC test on K64F and NUCLEO_F429ZI. It works good! It correctly detected broken multicast filtering on both boards. The STM32F4 issue will be fixed in my next PR, but the K64F one is a longer term project as it's simply unimplemented. |
JohnK1987
approved these changes
Jan 27, 2025
multiplemonomials
force-pushed
the
dev/emac-mem-manager-improvements
branch
from
January 28, 2025 07:54
78aa49e
to
c1d4487
Compare
multiplemonomials
force-pushed
the
dev/emac-test-improvements
branch
from
January 28, 2025 07:55
72d310e
to
1b922b5
Compare
multiplemonomials
force-pushed
the
dev/emac-test-improvements
branch
from
January 28, 2025 07:57
1b922b5
to
d17f6ab
Compare
multiplemonomials
force-pushed
the
dev/emac-mem-manager-improvements
branch
from
January 28, 2025 08:18
f04a0ff
to
714eeb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR does some refactoring and rewriting to improve the EMAC test. I have been working with this test suite a lot the last month or two and ended up making a number of fixes. This includes:
Impact of changes
Migration actions required
Documentation
Pull request type
Test results