Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the view-timeline-axis values for firefox #20293

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

dletorey
Copy link
Contributor

@dletorey dletorey commented Jul 4, 2023

Summary

Updated the notes for firefox for the view-timeline-axis so that it shows support for x & y.

Test results and supporting details

codepen showing:

  • view-timeline-axis: y;
  • view-timeline-axis: vertical;

Related issues

@github-actions github-actions bot added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Jul 4, 2023
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you search in BCD, this note is actually present on a few properties.
Query: https://github.com/search?q=repo%3Amdn%2Fbrowser-compat-data%20deprecated%20%3Ccode%3Ehorizontal%3C%2Fcode%3E&type=code

Should it be updated everywhere or was the fix just for view-timeline-axis?

@dletorey
Copy link
Contributor Author

dletorey commented Jul 4, 2023

If you search in BCD, this note is actually present on a few properties. Query: https://github.com/search?q=repo%3Amdn%2Fbrowser-compat-data%20deprecated%20%3Ccode%3Ehorizontal%3C%2Fcode%3E&type=code

Should it be updated everywhere or was the fix just for view-timeline-axis?

I tested this on:

  • animation-timeline scroll
  • scroll-timeline
  • scroll-timeline-axis
    And only horizontal/vertical work and not x/y

I have added this note to view-timeine

@dletorey dletorey requested a review from Elchi3 July 5, 2023 13:05
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dave! 👍

@Elchi3 Elchi3 merged commit 47e4525 into mdn:main Jul 10, 2023
@dletorey dletorey deleted the view-timeline-axis-ff-update branch November 29, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants