Fix the old cache deletion example. #37588
Open
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caches.forEach is not a valid method. You first need to use cache.keys to get a list of all caches.
StanleyMasinde
requested review from
sideshowbarker
and removed request for
a team
github-actions
bot
added
Content:WebAPI
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
files/en-us/web/api/serviceworkerglobalscope/activate_event/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/serviceworkerglobalscope/activate_event/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
caches.forEach is not a valid method. You first need to use cache.keys to get a list of all caches. The loop through them and delete what is not in the allow list.
Motivation
MDN is a GOTO place for Docs and this may cause a lot if frustration to those new to JavaScript.
Related issues and pull requests
N/A