FreshReleases: show more intermediary dates #3138
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a system to calculate dates to show on the timeline that depends on the number of releases for each day. If there is a long stretch of time without the required minimum releases, the timeline is suddently less useful and less clear. These modifications ensure a tick is shown for at minimum every week.
The existing code calculates a percentage value for each timeline entry based on all the releases available rather than the subset of dates that we actually show, which ended up skewing the percentages and making the timeline pretty useless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hot on the heels of a comment I made while testing #3125 , realizing our timeline looked very empty for me.
We have a system to decide which dates to show on the timeline that depends on the number of releases for each day.
If there is a long stretch of time without the required minimum releases, the timeline is suddenly very empty, less useful and less clear.
The modifications in this PR ensure a date is shown in the timeline at minimum every week.
Also small refactor while I'm in there.