Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor incremental stats framework #3147

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

amCap1712
Copy link
Member

Separate IncrementalStats class into Selector, Provider, MessageCreator and Aggregator. Builds on #3114, #3115, #3116.

Separate IncrementalStats class into Selector, Provider, MessageCreator and Aggregator.
@pep8speaks
Copy link

pep8speaks commented Jan 24, 2025

Hello @amCap1712! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 97:74: W292 no newline at end of file

Line 112:131: E501 line too long (133 > 130 characters)
Line 114:131: E501 line too long (133 > 130 characters)
Line 116:131: E501 line too long (133 > 130 characters)
Line 118:131: E501 line too long (133 > 130 characters)
Line 131:131: E501 line too long (135 > 130 characters)
Line 133:131: E501 line too long (135 > 130 characters)

Comment last updated at 2025-01-26 16:23:03 UTC

@amCap1712
Copy link
Member Author

This refactor is necessary for re-using code with the popularity data generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants