Update NodeJS version to 22.

metacall · Nov 5, 2024 · 0eed8f9 · 0eed8f9
1 parent b3df606
commit 0eed8f9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/cmake/CompileOptions.cmake b/cmake/CompileOptions.cmake
@@ -106,8 +106,7 @@ elseif(OPTION_BUILD_ADDRESS_SANITIZER AND (CMAKE_BUILD_TYPE STREQUAL "Debug" OR
 		# because we do not need to disable all features on all tests, this may hide bugs in the core library for example.
 
 		# Specify use_sigaltstack=0 as CoreCLR uses own alternate stack for signal handlers (https://github.com/swgillespie/coreclr/commit/bec020aa466d08e49e007d0011b0e79f8f7c7a62)
-		# Specify detect_container_overflow=0 as NodeJS 20.x triggers segmentation faults on MacOS 15
-		"ASAN_OPTIONS=detect_container_overflow=0:use_sigaltstack=0:symbolize=1:alloc_dealloc_mismatch=0:strict_string_checks=1:detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1:fast_unwind_on_malloc=0"
+		"ASAN_OPTIONS=use_sigaltstack=0:symbolize=1:alloc_dealloc_mismatch=0:strict_string_checks=1:detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1:fast_unwind_on_malloc=0"
 	)
 	set(SANITIZER_COMPILE_DEFINITIONS
 		"__ADDRESS_SANITIZER__=1"

diff --git a/tools/metacall-environment.sh b/tools/metacall-environment.sh
@@ -537,13 +537,13 @@ sub_nodejs(){
 		# 	echo "-DNPM_ROOT=$NODE_PREFIX" >> $CMAKE_CONFIG_PATH
 		# else
 
-		brew install node@20
-		# Make node 20 the default
-		brew link node@20 --force --overwrite
+		brew install node@22
+		# Make node 22 the default
+		brew link node@22 --force --overwrite
 		# Execute post install scripts
-		brew postinstall node@20
+		brew postinstall node@22
 		# Define node location
-		NODE_PREFIX=$(brew --prefix node@20)
+		NODE_PREFIX=$(brew --prefix node@22)
 		# Include binaries into PATH
 		export PATH="$NODE_PREFIX/bin:$PATH"