refactor: tackle corner cases and change variable names for better readability

[khareyash05]

Signed-off-by: Yash yash2010118@akgec.ac.in

• Completed TODO for serveStatic
• Added corner cases and error handling for deleting applications
• Renamed variables so they are easier to read and understand their functionality
• Added more error cases for applications

[Creatoon]

remove these two newly added cases, as they are not required, as the response is for user not the developer.

Remove the logic for folderShouldntExist, appShouldntExist, as all the cases are handled properly.

Also Dont use multiple return statements.

[khareyash05]

Hey ! Thanks for the review I really dont think the cases are being handled properly. for example when scaling it for future there may be cases when the system disconects or any other simultaneous processes may block the current proccesses. I think these cases will be need and thus multiple return statements are necessary. Let me know if there are any alternate thoughts you have to the same.

[khareyash05]

I see we shouldnt send it to the user but we need to handle these cases at the backend side IMHO

[viferga]

@khareyash05 for me it seems correct, I do not understand what @Creatoon said respect to the error messages. Can you update the conflicts to make it work again with the latest changes?

Once you do that I will merge your PR.

[khareyash05]

@khareyash05 for me it seems correct, I do not understand what @Creatoon said respect to the error messages. Can you update the conflicts to make it work again with the latest changes?

Once you do that I will merge your PR.

Resolved the conflicts. Maybe we are unable to comprehend what @Creatoon wants to say. If there is something I might be missing. Let me know. Thanks @viferga

[viferga]

I passed the CI and after my change of considering all warnings as errors (of the linter), your CI execution failed:
https://github.com/metacall/faas/actions/runs/8294111642/job/22775896259?pr=38

Correct this linter issue and I will merge it.

[khareyash05]

I passed the CI and after my change of considering all warnings as errors (of the linter), your CI execution failed: https://github.com/metacall/faas/actions/runs/8294111642/job/22775896259?pr=38

Correct this linter issue and I will merge it.

fixed. Kindly rerun the CI

[giarve]

I passed the CI and after my change of considering all warnings as errors (of the linter), your CI execution failed: https://github.com/metacall/faas/actions/runs/8294111642/job/22775896259?pr=38
Correct this linter issue and I will merge it.

fixed. Kindly rerun the CI

Done, sorry for the long wait

[viferga]

@khareyash05 seems to be still failing.

[viferga]

I am merging this and I will solve the issues by myself.

[khareyash05]

Thanks @viferga .