Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing eslint issue #40

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Removing eslint issue #40

merged 2 commits into from
Mar 13, 2024

Conversation

HeeManSu
Copy link
Contributor

@HeeManSu HeeManSu commented Mar 12, 2024 •
edited
Loading

  • eslint issues are currently disabled manually.
  • This PR includes refactoring the existing codebase for eslint issues.
  • Incomplete currently, Don't merge it.

@Creatoon
Copy link
Contributor

Hey @HeeManSu This is not required as diffing function will not just be used for diffing inspect objects, it's a generic function to diff any kind of object, that's why we don't have to apply type check here for inspect kind of objects.

Thanks

@HeeManSu HeeManSu marked this pull request as draft March 12, 2024 16:03
@viferga viferga marked this pull request as ready for review March 13, 2024 17:54
@viferga viferga merged commit f1c1c48 into metacall:master Mar 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HeeManSu @Creatoon @viferga