Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AdvancedPaste] Add all supported image filetypes to ImageToText #35600

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −2
Open

[AdvancedPaste] Add all supported image filetypes to ImageToText #35600

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26fe5ae
Adds support to ImageToText for all image filetypes supported by Bitm…
daverayment Oct 25, 2024
5135506
Merge branch 'main' into pr35600
jaimecbernardo Nov 22, 2024
cda094f
Merged main, fixed conflicts
drawbyperpetual Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/modules/AdvancedPaste/AdvancedPaste/Helpers/DataPackageHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ namespace AdvancedPaste.Helpers;

internal static class DataPackageHelpers
{
private static readonly HashSet<string> ImageFileTypes = new(StringComparer.InvariantCultureIgnoreCase) { ".png", ".jpg", ".jpeg", ".gif", ".bmp", ".tiff", ".ico", ".svg" };
private static readonly Lazy<HashSet<string>> ImageFileTypes = new(GetImageFileTypes());

private static readonly (string DataFormat, ClipboardFormat ClipboardFormat)[] DataFormats =
[
Expand Down Expand Up @@ -57,7 +57,7 @@ internal static async Task<ClipboardFormat> GetAvailableFormatsAsync(this DataPa
{
availableFormats |= ClipboardFormat.File;

if (ImageFileTypes.Contains(file.FileType))
if (ImageFileTypes.Value.Contains(file.FileType))
{
availableFormats |= ClipboardFormat.Image;
}
Expand Down Expand Up @@ -148,4 +148,9 @@ private static async Task<IRandomAccessStream> GetImageStreamAsync(this DataPack

return null;
}

private static HashSet<string> GetImageFileTypes() =>
BitmapDecoder.GetDecoderInformationEnumerator()
.SelectMany(di => di.FileExtensions)
.ToHashSet(StringComparer.InvariantCultureIgnoreCase);
}
Loading