Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing failed lookup locations when resolving bare-specifier package.json "imports" #60924

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+462 −0
Open

Fix missing failed lookup locations when resolving bare-specifier package.json "imports" #60924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
711ebf1
Add failing test
andrewbranch Jan 6, 2025
77d0144
Add missing failed lookup locations
andrewbranch Jan 6, 2025
50153bc
Remove readonly annotation and comment instead
andrewbranch Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/compiler/moduleNameResolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2756,6 +2756,11 @@ function getLoadModuleFromTargetExportOrImport(extensions: Extensions, state: Mo
traceIfEnabled(state, Diagnostics.Using_0_subpath_1_with_target_2, "imports", key, combinedLookup);
traceIfEnabled(state, Diagnostics.Resolving_module_0_from_1, combinedLookup, scope.packageDirectory + "/");
const result = nodeModuleNameResolverWorker(state.features, combinedLookup, scope.packageDirectory + "/", state.compilerOptions, state.host, cache, extensions, /*isConfigLookup*/ false, redirectedReference, state.conditions);
// Note: we cannot safely reassign `state.failedLookupLocations` during a request;
// `nodeModuleNameResolverWorker` relies on the `state` property remaining reference-equal
// to the one it initializes.
state.failedLookupLocations?.push(...result.failedLookupLocations ?? emptyArray);
state.affectingLocations?.push(...result.affectingLocations ?? emptyArray);
return toSearchResult(
result.resolvedModule ? {
path: result.resolvedModule.resolvedFileName,
Expand Down
Loading
Loading