-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Tasks on MacOS agents not completing but marked as succeeded. #5079
Open
sahilbhattMS
wants to merge
53
commits into
master
Choose a base branch
from
users/sahilbhatt/debug_monitor_tracing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocesstreekillattempt arg
sahilbhattMS
changed the title
FIX: No-opping tasks in MacOS agents
FIX: Tasks on MacOS agents not completing but marked as succeeded.
Jan 6, 2025
merlynomsft
reviewed
Jan 7, 2025
merlynomsft
reviewed
Jan 7, 2025
merlynomsft
reviewed
Jan 7, 2025
merlynomsft
reviewed
Jan 8, 2025
merlynomsft
reviewed
Jan 8, 2025
tarunramsinghani
approved these changes
Jan 9, 2025
merlynomsft
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Some pipelines using MacOS agents reported tasks not completing but still being marked as succeeded. Disabling resource utilization warnings seemed to mitigate this issue.
An analysis of various debug logs indicated that the problem was due to the resource utilization warnings' implementation in MacOS, where multiple CPU and memory info processes were being invoked simultaneously.
Changes made:
Validations done:
The issue did not reproduce on running a test pipeline on a self-hosted MacOS agent using the above-mentioned changes.