-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fnllm Updates #326
fnllm Updates #326
Conversation
Regarding load times... Have you considered looking into the init files and separate by modules? for example, leave the Limiters stuff in fnllm.limiters, and exposing less things into the fnllm package? |
That's not a bad idea, but it's probably worth a longer discussion on how to break that apart. We could just expose top-level types from fnlm, or we could expose nothing; let's address breaking down the barrel-files in a future PR |
Just to add on top of Andres' comment. The benefit from type check imports isn't that significant, surely improves time (and Ruff checks them) but the bang for the buck is minimizing how much you're exposing on your top level modules. If everything rolls up to top level, you're basically loading everything and not benefiting from how the Python interpreter lazy loads this stuff. We did this on graphRAG and load time went from 2 minutes to seconds. |
fixes #325