feat: add highlight for selection and fix svg rendering #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am currently getting some strange errors when trying to run yarn version check --interactive which is blocking the CI build |
|
🤷♂️ the version check tool looked fine to me |
darthtrevino
added a commit
that referenced
this pull request
Feb 7, 2022
* feat: add highlight for selection and fix svg rendering * cut semver * fix lint issues Co-authored-by: Amber Hoak <amhoak@microsoft.com> Co-authored-by: Chris Trevino <chtrevin@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue Allow selected row sync #44 that has selection props for Hierarchy Browser and a callback that will return entityIds of new selection state. The new props for Hierarchy Browser are:
selections: optional array of entityIds
onSelectionChange: function that returns the new selection state
This allows for multi-select and deselect.
I added these changes to the HierarchyBrowser Async story.
Sidenote: I noticed some issues in rendering the SVG bar for the "neighbors" column so I fixed this by having a default height per cell.