Add iOS shared color tokens (error, status, and presence) #2520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Follow up to #2481
In the change above we added neutral and brand alias color tokens. There was still some ongoing discussion on shared color tokens (i.e. error, status, and presence tokens) at the time, but that's been resolved and those tokens have been added to the design-tokens repo. Updating iOS alias color tokens to include these new tokens.
After this change, the full set of the iOS alias tokens will be available.
Verification
Realized that the existing Tokens test page was actually getting updated with the iOS alias tokens changes - videos for light/dark mode below, the new shared colors that were added are at the bottom:
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-01-13.at.10.39.46.mp4
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-01-13.at.10.39.25.mp4
Pull request checklist
This PR has considered (when applicable):