Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to React Native 0.74 #3784

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Saadnajmi
Copy link
Collaborator

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

Run rnx-align-deps with the 0.74 requirement and fix as many warnings as we can.

Verification

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@Saadnajmi Saadnajmi requested a review from a team as a code owner October 9, 2024 02:39
Comment on lines 42 to 43
"@office-iss/react-native-win32": "^0.73.0",
"@office-iss/rex-win32": "0.73.11-devmain.16.0.17614.15010",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should all the win32 packages also be bumped?

@@ -5739,7 +5943,7 @@ __metadata:
languageName: node
linkType: hard

"@react-native-community/cli-platform-ios@npm:12.3.7, @react-native-community/cli-platform-ios@npm:^12.1.1":
"@react-native-community/cli-platform-ios@npm:12.3.7":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some old packages in here still. Probably because of the win32 packages.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there be a diff for ios/Podfile.lock as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants