Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cuda pipeline #1202

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Fix cuda pipeline #1202

merged 1 commit into from
Jan 24, 2025

Conversation

baijumeswani
Copy link
Collaborator

No description provided.

@baijumeswani baijumeswani requested review from a team, ajindal1, RyanUnderhill, kunal-vaishnavi and aciddelgado and removed request for a team January 23, 2025 19:48
Copy link
Member

@RyanUnderhill RyanUnderhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the kind of fix I expected, but it works.

How fragile is this? Like if it ever fails again should there be a comment on how to know what's the correct output?

@baijumeswani
Copy link
Collaborator Author

How fragile is this? Like if it ever fails again should there be a comment on how to know what's the correct output?

This is as fragile as the underlying model. If there are changes to the underlying model (as was the case with the HF change), then the expected output will change. If we pin all versions (onnxruntime, hf-tranformers), then we won't see this problem again.

@baijumeswani baijumeswani merged commit 34847a2 into main Jan 24, 2025
15 checks passed
@baijumeswani baijumeswani deleted the baijumeswani/fix-cuda-pipeline branch January 24, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants