virt_mshv_vtl: Share common processing between poll_apic implementations #630
+233
−218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalis-msft
commented
Jan 8, 2025
|
|
||
| pub(crate) fn poll_apic_core<T: ApicBacking>( | ||
| processor: &mut T, | ||
| scan: impl Fn(&mut T) -> ApicWork, |
There was a problem hiding this comment.
These closures could all move onto ApicBacking if we want, just creates a larger diff.
smalis-msft
commented
Jan 8, 2025
| @@ -392,61 +392,22 @@ impl BackingPrivate for SnpBacked { | |||
| vtl: GuestVtl, | |||
| scan_irr: bool, | |||
| ) -> Result<(), UhRunVpError> { | |||
| // Check for interrupt requests from the host. | |||
| // TODO SNP GUEST VSM supporting VTL 1 proxy irrs requires kernel changes | |||
There was a problem hiding this comment.
This comment (and the corresponding one in TDX) are gone now, as John and I decided that we don't plan on implementing this in the near future. Just doesn't seem to be worthwhile.
smalis-msft
force-pushed
the
share-apic-poll
branch
from
9b7b8e6 to
9e6782e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is far from the cleanest code I've ever written, but it accomplishes my goal of sharing the tricky and involved checks between all of our poll_apic implementations. Having something like this would've saved me some pain with TDX recently. Definitely open for feedback on design and bikeshedding, I just wanted to get out a min viable refactoring, that created as small a diff as I could, to see if it was doable.
Still needs CVM testing