ide: mark PRD as exhausted even if on buffer boundary #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this. How did you find this? (was this a fuzzer-found bug)? |
This is a resubmit on a fix attempted on the old repo months ago. There were still some testing issues with that fix, but with recent changes to vmm-tests, I am re-running to see if they are now resolved. |
mattkur
changed the title
Got it. Can you do two things?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PRD table can become exhausted early without the exhaustion flag being set because the buffer is not fully exhausted, leaving the disk waiting for remaining data that will never come. Additionally, the exhaustion logic for reads needs to also be copied for writes.