Petri: Hyper-V support #644
Open
+1,681
−249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarks
reviewed
Jan 10, 2025
| path, | ||
| ), | ||
| #[cfg(windows)] | ||
| ImageType::Vhd => build_disk_image_vhd( |
There was a problem hiding this comment.
Don't do this. Just build a raw image and then call disk_vhd1::Vhd1Disk::make_fixed.
There was a problem hiding this comment.
Oh cool I didn't know we had that
jstarks
reviewed
Jan 10, 2025
| @@ -278,7 +278,7 @@ impl SimpleFlowNode for Node { | |||
|
|
|||
| if add_hyperv_pipette_reg_key && rt.platform() == FlowPlatform::Windows { | |||
| let sh = xshell::Shell::new()?; | |||
| xshell::cmd!(sh, "reg add \"HKLM\\SOFTWARE\\Microsoft\\Windows NT\\CurrentVersion\\Virtualization\\GuestCommunicationServices\\00001337-facb-11e6-bd58-64006a7986d3\" /v ElementName /t REG_SZ /d \"pipette\" /f").run()?; | |||
| xshell::cmd!(sh, "MSYS_NO_PATHCONV=1 reg add \"HKLM\\SOFTWARE\\Microsoft\\Windows NT\\CurrentVersion\\Virtualization\\GuestCommunicationServices\\00001337-facb-11e6-bd58-64006a7986d3\" /v ElementName /t REG_SZ /d \"pipette\" /f").run()?; | |||
There was a problem hiding this comment.
What makes you think we're going through msys/cygwin?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for running Hyper-V VMM tests to Petri. Includes functionality to run basic boot test, more configuration options will be added in future PRs to run more specialized tests.