chore: add APP_INSIGHTS_ID to image build #1266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Castilio dos Santos <alexsantos@microsoft.com>
alexcastilio
force-pushed
the
alexcastilio/app-insights-in-image
branch
3 times, most recently
from
fd1f6a8 to
e175158
Compare
alexcastilio
force-pushed
the
alexcastilio/app-insights-in-image
branch
from
e175158 to
585155c
Compare
Signed-off-by: Alex Castilio dos Santos <alexsantos@microsoft.com>
alexcastilio
force-pushed
the
alexcastilio/app-insights-in-image
branch
from
585155c to
b82c68c
Compare
matmerr
reviewed
Jan 24, 2025
| @@ -35,5 +37,10 @@ func GetConfig(cfgFileName string) (*OperatorConfig, error) { | |||
| return nil, fmt.Errorf("error unmarshalling config: %w", err) | |||
| } | |||
|
|
|||
| // If unset, default telemetry interval to 5 minutes. | |||
| if cfg.TelemetryInterval == 0 { | |||
| cfg.TelemetryInterval = 5 * time.Minute | |||
There was a problem hiding this comment.
let's keep to 15min, and since this is a configmap change we'll need to notify a few people
There was a problem hiding this comment.
I think it would be better if a zero value TelemetryInterval means no telemetry/the previous behavior. That keeps any changed behavior intentionally opt-in, backcompat, and obvious
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
deploy/standard/manifests/controller/helm/retina/values.yamlRelated Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Manual test was also done to validate that the configuration was propagated from helm chart
values.yamlfile to both operator and agent. Value set was printed to log:Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.