Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs and nuget ref in samples #2379

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

benjaminpetit
Copy link
Member

@benjaminpetit benjaminpetit commented Jan 18, 2024

Fix #2345 and fixes #2352

@benjaminpetit benjaminpetit added the Type: Documentation Improvements or additions to documentation label Jan 18, 2024
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@@ -6,7 +6,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Yarp.ReverseProxy" Version="2.0.0" />
<PackageReference Include="Yarp.ReverseProxy" Version="2.1.0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also update the Yarp.Telemetry.Consumption references

<PackageReference Include="Yarp.Telemetry.Consumption" Version="2.0.0" />

<PackageReference Include="Yarp.Telemetry.Consumption" Version="2.0.0" />

@benjaminpetit benjaminpetit merged commit 4879823 into microsoft:release/latest Jan 18, 2024
6 checks passed
@MihaZupan MihaZupan added this to the YARP 2.1 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants