change the test project to reference cadl ranch source code projects instead of including their source code #5570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArcturusZhang
added
the
emitter:client:csharp
ArcturusZhang
commented
Jan 10, 2025
...lient-csharp/generator/TestProjects/CadlRanch.Tests/Http/Payload/Multipart/MultipartTests.cs
Show resolved
Hide resolved
|
API change check API changes are not detected in this pull request. |
.../http-client-csharp/generator/TestProjects/CadlRanch.Tests/Http/Client/Naming/NamingTests.cs
Outdated
Show resolved
Hide resolved
...s/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Properties/launchSettings.json
Outdated
Show resolved
Hide resolved
...p-client-csharp/generator/TestProjects/CadlRanch.Tests/Http/Parameters/Spread/SpreadTests.cs
Outdated
Show resolved
Hide resolved
...harp/generator/TestProjects/CadlRanch.Tests/Http/Resiliency/SrvDriven/V2/SrvDrivenV2Tests.cs
Outdated
Show resolved
Hide resolved
...ttp-client-csharp/generator/TestProjects/CadlRanch.Tests/TestProjects.CadlRanch.Tests.csproj
Outdated
Show resolved
Hide resolved
ArcturusZhang
commented
Jan 16, 2025
.../TestProjects/CadlRanch.Tests/Http/Versioning/RenamedFrom/V1/VersioningRenamedFromV1Tests.cs
Outdated
Show resolved
Hide resolved
packages/http-client-csharp/eng/scripts/Get-CadlRanch-Coverage.ps1
Outdated
Show resolved
Hide resolved
ArcturusZhang
changed the title
ArcturusZhang
commented
Jan 16, 2025
...ttp-client-csharp/generator/TestProjects/CadlRanch.Tests/TestProjects.CadlRanch.Tests.csproj
Show resolved
Hide resolved
JoshLove-msft
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5564
Comparing with our previous "adding new cadl ranch case" process, now we have an additional step of "adding the new cadl ranch source code project into the
generator\TestProjects\CadlRanch.Tests\TestProjects.CadlRanch.Tests.csprojfile, with an alias when needed.