Add containerapps-albumapi-javascript test project & cases
#696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicroFish91
changed the title
mslearn-js test project/casesmslearn-js test project & cases
MicroFish91
changed the title
mslearn-js test project & casescontainerapps-albumapi-javascript test project & cases
…ode-azurecontainerapps into mwf/albumapi-js-test
…ode-azurecontainerapps into mwf/albumapi-js-test
…inerapps into mwf/nightly-test-prep
…vscode-azurecontainerapps into mwf/add-monorepo-test-project
…ode-azurecontainerapps into mwf/albumapi-js-test
| @@ -0,0 +1,10 @@ | |||
| FROM node:lts-alpine | |||
There was a problem hiding this comment.
Have you verified that making this Dockerfile invalid breaks the tests?
There was a problem hiding this comment.
Thinking about this more, it might be good to explore making a test case with a broken Dockerfile on purpose so we have a consistent and tested experience for that.
There was a problem hiding this comment.
Great suggestion, I'm working on an update to address this here!
#708
MicroFish91
force-pushed
the
mwf/albumapi-js-test
branch
from
16504ba to
8fc527b
Compare
alexweininger
approved these changes
Jun 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall test todos outlined here: #697
Closes #699