Add Azure Stacks WebSiteManagementClient #1218
Conversation
|
Actually, I can just pack and install this to Functions and make a custom VSIX to test Azure Stacks, so I'll hold off on merging until then. |
| @@ -34,6 +34,7 @@ | |||
| "dependencies": { | |||
| "@azure/abort-controller": "^1.0.4", | |||
| "@azure/arm-appinsights": "^5.0.0-beta.4", | |||
| "@azure/arm-appservice-profile-2020-09-01-hybrid": "^2.0.0", | |||
There was a problem hiding this comment.
Can this replace @azure/arm-appservice entirely? I'm apprehensive to add more dependencies to this already gargantuan package...
There was a problem hiding this comment.
Especially until I can get to microsoft/vscode-docker#3594
There was a problem hiding this comment.
We definitely can't replace the @azure/arm-appservice package with this one as the api-versions are different. I'm pretty sure that this only works with custom cloud. That being said, I understand the apprehension to adding more dependencies.
There was a problem hiding this comment.
What is it about the primary @azure/arm-appservice package that makes it incompatible with Azure Stack?
There was a problem hiding this comment.
microsoft/vscode-azurefunctions#3242 The api-version itself which we can't dynamically change unfortunately.
There was a problem hiding this comment.
This seems like an easy thing for the SDK to handle...should we file an issue for it?
There was a problem hiding this comment.
Yeah or ideally they adopt the hybrid SDKs with the new REST sdks that are much smaller.
|
Closing as stale. |
I tried replacing the
WebSiteManagementClienttype with the new hybrid version, and besides some mismatch typing in Site response, it seems like it has all of the same namespaces and operations.I bumped a minor version though because I think that this could sort of be considered a breaking change though realistically, shouldn't impact 99% of people since they won't have
isCustomCloudset.