Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Poetry to UV #146

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Switch from Poetry to UV #146

wants to merge 3 commits into from

Conversation

lebrice
Copy link
Contributor

@lebrice lebrice commented Jan 21, 2025

Signed-off-by: Fabrice Normandin normandf@mila.quebec

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@lebrice
Copy link
Contributor Author

lebrice commented Jan 21, 2025

Hey @breuleux , I'm getting some gifnoc errors: https://github.com/mila-iqia/SARC/actions/runs/12891808082/job/35944599043#step:6:463

The version that gets installed now is 0.4.1 (the original requirement was for gifnoc = "^0.2.3" before switching to UV.
Am I using the right version (0.4.1) ? Or should I limit gifnoc to only match an earlier version?

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
@breuleux
Copy link
Member

@lebrice I usually bump the major or first nonzero version number when I make breaking changes, so it's quite possible that moving from 0.2.x to 0.3.x or 0.4.x would break stuff. "^0.2.3" is shorthand for ">=0.2.3<0.3" if I am not mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants