[SARC-312] Update @satyaog code from PR #115 to harmonize GPU names #148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette PR s'inspire de la PR #115 pour convertir les
gpu_type
des nodes en noms plus descriptifs.Les noms descriptifs des GPUs sont censés être les mêmes que ceux utilisés dans le package IGUANE: https://github.com/mila-iqia/IGUANE/blob/master/iguane/rawdata.toml
La PR actuelle se content d'ajouter une méthode
ClusterConfig.harmonize_gpu(nodename, gpu_type) -> str
qui retourne le nom descriptif pour un nodename (e.g.cdr1234
) et un gpu_type (e.g.a100
) donnés. J'ai préféré ne pas modifier les jobs pour le moment (job.alllocated.gpu_type
retourne toujours les gpu_types tels qu'on les connait actuellement).