Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for the minimal examples #264

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Jan 14, 2025

Signed-off-by: Fabrice Normandin fabrice.normandin@gmail.com

lebrice and others added 7 commits January 14, 2025 15:58
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>

Make all job script executable

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>

Move common stuff to a `run_example` function

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>

Add regex substitutions before comparing outputs

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>

Make the Pytorch-based examples reproducible

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>

Reduce the number of GPUs per node from 4 to 2

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>

Unified test for pytorch-based examples

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>

Add a `make_env.sh` sbatch script in pytorch setup

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>

Simplify the `test_examples.py` file

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>

Update the regression files for the examples

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>

Add regression file for multi-node example

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>

Add the `pip install orion` line to Orion example

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>

Add a test for the checkpointing example

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>

Add the regression files for checkpointing example

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>

Fix regression file for the ckpt example test

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>

Split test code into testutils and test file

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>

Start to add test for "HPO with Orion" example

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>

Remove potentially buggy asserts

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>

Make a conda env for the Orion example

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant