Limit allowed redirect URLs from GetAuthorizationURL #5282
Merged
+61
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, it is possible to set an arbitrary redirect URL after completing Minder login. Limit this to localhost (for CLI), or known endpoints in our config.
Change Type
Mark the type of change your PR introduces:
Testing
Added unit tests -- I'm wondering if we should put this behind a configuration option as well for easier rollback if I got something wrong.
Review Checklist: