Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit allowed redirect URLs from GetAuthorizationURL #5282

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

evankanderson
Copy link
Member

Summary

Currently, it is possible to set an arbitrary redirect URL after completing Minder login. Limit this to localhost (for CLI), or known endpoints in our config.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Added unit tests -- I'm wondering if we should put this behind a configuration option as well for easier rollback if I got something wrong.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@evankanderson evankanderson requested a review from a team as a code owner January 10, 2025 08:00
@coveralls
Copy link

Coverage Status

coverage: 56.595% (+0.006%) from 56.589%
when pulling 086724d on evankanderson:controlled-redirects
into 14b2907 on mindersec:main.

@evankanderson evankanderson merged commit f2e2365 into mindersec:main Jan 10, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants