Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update due to rename of 'mysql' to 'mysql8.4' #1348

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

FaramosCZ
Copy link
Contributor

Resolves: RHEL-73703

Copy link
Collaborator

@yselkowitz yselkowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, Fedora (and hence ELN) has only 8.0, and is currently still unversioned. Therefore, the configs need to be split, with this become eln-only and unversioned (for now) and a new -c10s config with this applied.

@FaramosCZ
Copy link
Contributor Author

Right, I suspected that.

--

Additional info:
Actually, in Fedora, the package 'mysql' is replaced by 'mysql8.0' too, since F40:
https://src.fedoraproject.org/rpms/mysql8.0

The difference is that the Fedora package provides also the unversioned names, so the content resolver is likely fine with those.

--

To clear the confusion, maybe it would be best that I would create two entirely new workloads, one for 'mysql8.0' for Fedora, listing the versioned names (as there is a plan to dynamically change between Fedora releases which of the different MySQL series in Fedora will be the only one that provides the unversioned names) to be sure they are picked up correctly in any case.

The other workload for 'mysql8.4' for RHEL 10.
The 8.4 is planned for Fedora too, just haven't left Fedora review yet.

At the same time I'd retire the current (unvrsioned) workload entirely. (F39 is EOL already)

--

How does it sound to you?
Any suggestions or reservations?

@FaramosCZ
Copy link
Contributor Author

I implemented the changes I described above,
please re-review @yselkowitz

The unversioned 'mysql' package has been transformed to
versioned variants 'mysql8.0' and 'mysql8.4'.

The Fedora package 'mysql8.0' also provides the unversioned 'mysql' names,
while the c10s 'mysql8.4' package does not.

Resolves: RHEL-73703
@yselkowitz
Copy link
Collaborator

To be clear, ELN (like rawhide) has a 8.0 versioned SRPM but the RPMs are still unversioned. In any case, they provide the versioned names, so this should work for now. While the RHEL changes need to be finished first due to timing, at some point I would like to get the ELN packages to follow the new pattern by changing mysqlX.Y.spec:

@@ -9,1 +9,1 @@
-%{!?mysql_default:%global mysql_default 1}
+%{!?mysql_default:%global mysql_default %{undefined rhel}}

And as previously mentioned, perl-DBD-MySQL will need to be updated as well.

@yselkowitz yselkowitz merged commit 382feb5 into minimization:main Jan 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants