[WIP] Changes for Gtzan dataset #569
Conversation
harshpalan
changed the title
| from mirdata.datasets import compmusic_carnatic_rhythm | ||
| except ImportError: | ||
| raise ImportError( | ||
| "In order to use CompMusic Carnatic Music Rhythm you must have openpyxl installed. " |
There was a problem hiding this comment.
I would propose this just because the exception is a bit more general and it can fail in other ways rather than missing dependencies.
"An error occured when importing this dataset. Most likely this is due to a dependency not being installed, in this case openpyxl."
There was a problem hiding this comment.
sure, I'll make the changes.
| @@ -4,11 +4,10 @@ | |||
| try: | |||
| import DALI | |||
| except ImportError: | |||
| logging.error( | |||
| raise ImportError( | |||
There was a problem hiding this comment.
Yeah, the same thing as above:
"An error occured when importing this dataset. Most likely this is due to "
| @@ -4,11 +4,10 @@ | |||
| try: | |||
| import music21 | |||
| except ImportError: | |||
| logging.error( | |||
| raise ImportError( | |||
There was a problem hiding this comment.
"An error occured when importing this dataset. Most likely this is due to "
|
Let's fix #564 here as well |
magdalenafuentes
changed the title
Codecov Report
@@ Coverage Diff @@
## master #569 +/- ##
==========================================
+ Coverage 96.96% 97.02% +0.05%
==========================================
Files 58 58
Lines 6990 6987 -3
==========================================
+ Hits 6778 6779 +1
+ Misses 212 208 -4 |
…mirdata into WindowsCompatibility
As discussed with @magdalenafuentes, I have made the changes for some issues and the gtzan dataset (dataset not available anymore).
One of these changes is adding optional dependencies to the test in
setup.pyso users can quickly test mirdata without facing any issues.@genisplaja @nkundiushuti please review and let me know if any changes are required.
Fixes #568 , #562, #564, #549