Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): 投稿フォームの絵文字ピッカーに独立したウィンドウを使用できるように #15291

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Jan 15, 2025

What

image

絵文字ピッカーのスタイルの一つとして「ウィンドウ」を復活

  • 投稿フォームを閉じたり、投稿フォームを含むページから離脱したりしたら絵文字ピッカーウィンドウを自動で閉じるように
  • 絵文字ピッカーウィンドウは一つしか開けない

Why

Fix #15290

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 17.75148% with 139 lines in your changes missing coverage. Please review.

Project coverage is 18.87%. Comparing base (68175bc) to head (b4935ea).

Files with missing lines Patch % Lines
...es/frontend/src/components/MkEmojiPickerWindow.vue 0.00% 71 Missing and 1 partial ⚠️
packages/frontend/src/scripts/emoji-picker.ts 12.50% 49 Missing ⚠️
...kages/frontend/src/pages/settings/emoji-picker.vue 0.00% 9 Missing ⚠️
...src/components/MkEmojiPickerWindow.stories.impl.ts 0.00% 6 Missing and 1 partial ⚠️
packages/frontend/src/store.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15291       +/-   ##
============================================
- Coverage    37.76%   18.87%   -18.89%     
============================================
  Files         1601      764      -837     
  Lines       203886   110766    -93120     
  Branches      3711     1233     -2478     
============================================
- Hits         76988    20911    -56077     
+ Misses      126256    89268    -36988     
+ Partials       642      587       -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

投稿フォームの絵文字ピッカーに独立したウィンドウを使用できるように
1 participant