Skip to content

Commit

Permalink
xgettext: remove dependency on libstdc++-6 because of thread safety (#23
Browse files Browse the repository at this point in the history
)

* xgettext: remove dependency on libstdc++-6 because of thread safety

When thread safety is enabled, xgettext uses the two functions
__cxa_guard_acquire and __cxa_guard_release of libstdc++-6.dll

* Use only -fno-threadsafe-statics to remove dependency on libstdc++-6

See:
- https://lists.gnu.org/archive/html/bug-gettext/2024-10/msg00008.html
- https://lists.gnu.org/archive/html/bug-gettext/2024-10/msg00010.html
  • Loading branch information
mlocati authored Oct 3, 2024
1 parent 9a5c0b3 commit b132eec
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ jobs:
../configure \
CPPFLAGS='${{ steps.vars.outputs.cpp-flags }}' \
LDFLAGS='${{ steps.vars.outputs.ld-flags }}' \
CXXFLAGS='${{ steps.vars.outputs.cxx-flags }}' \
${{ steps.vars.outputs.configure-args }} \
--prefix=$INSTALLED_PATH
-
Expand Down Expand Up @@ -199,6 +200,7 @@ jobs:
../configure \
CPPFLAGS="-I$INSTALLED_PATH/include ${{ steps.vars.outputs.cpp-flags }}" \
LDFLAGS="-L$INSTALLED_PATH/lib ${{ steps.vars.outputs.ld-flags }}" \
CXXFLAGS='${{ steps.vars.outputs.cxx-flags }}' \
${{ steps.vars.outputs.configure-args }} \
--disable-java \
--disable-native-java \
Expand Down
1 change: 1 addition & 0 deletions build-exe/vars.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ $gnuUrlPrefixer.WriteWarning()
"configure-args=$configureArgs" | Out-File -FilePath $env:GITHUB_OUTPUT -Append -Encoding utf8
"cpp-flags=-I/usr/$mingwHost/sys-root/mingw/include -g0 -O2" | Out-File -FilePath $env:GITHUB_OUTPUT -Append -Encoding utf8
"ld-flags=-L/usr/$mingwHost/sys-root/mingw/lib" | Out-File -FilePath $env:GITHUB_OUTPUT -Append -Encoding utf8
"cxx-flags=-fno-threadsafe-statics" | Out-File -FilePath $env:GITHUB_OUTPUT -Append -Encoding utf8
"iconv-source-url=$iconvSourceUrl" | Out-File -FilePath $env:GITHUB_OUTPUT -Append -Encoding utf8
"gettext-source-url=$gettextSourceUrl" | Out-File -FilePath $env:GITHUB_OUTPUT -Append -Encoding utf8
"gettext-ignore-tests-c=$gettextIgnoreTestsC" | Out-File -FilePath $env:GITHUB_OUTPUT -Append -Encoding utf8
Expand Down

0 comments on commit b132eec

Please sign in to comment.