Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the incorrect call in SafeRef. #3143

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Fix the incorrect call in SafeRef. #3143

merged 1 commit into from
Feb 4, 2025

Conversation

kkwpsv
Copy link
Contributor

@kkwpsv kkwpsv commented Jan 22, 2025

Description of Change

SafeRef should call sk_refcnt_safe_ref instead sk_refcnt_safe_unref.

Bugs Fixed

Fix the incorrect behavior of SafeRef.

API Changes

None.

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

Copy link
Contributor

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! How long was this here for????

@mattleibow
Copy link
Contributor

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mattleibow
Copy link
Contributor

Also, welcome to SkiaSharp!

@mattleibow mattleibow merged commit 84f5eea into mono:main Feb 4, 2025
2 of 3 checks passed
@kkwpsv
Copy link
Contributor Author

kkwpsv commented Feb 5, 2025

Wow! How long was this here for????

Seems to be this since the beginning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants