change carthage refs and documentation for xcode 10.2 (#946)

* change carthage refs and documentation for xcode 10.2

* fix settinglistviewspec

Cartfile

@@ -6,7 +6,7 @@ github "RxSwiftCommunity/RxOptional" ~> 3.1.3
 github "mozilla-mobile/telemetry-ios"
 github "jrendel/SwiftKeychainWrapper" ~> 3.0
 github "mozilla-mobile/MappaMundi" "master"
-github "mozilla/application-services" "v0.22.1"
+github "garvankeeley/application-services"      "0.27.0.1" # for xcode 10.2 compat use this fork temporarily
 github "adjust/ios_sdk" ~> 4.14.1
 github "getsentry/sentry-cocoa" "4.1.0"
 github "ashleymills/Reachability.swift" "v4.3.0"

Cartfile.resolved

@@ -1,13 +1,13 @@
 github "Quick/Nimble" "v8.0.1"
-github "Quick/Quick" "v2.0.0"
+github "Quick/Quick" "v2.1.0"
 github "ReactiveX/RxSwift" "4.5.0"
 github "RxSwiftCommunity/RxDataSources" "81b709c28b8ceb5cddc8c2262d009ea8735f0893"
-github "RxSwiftCommunity/RxOptional" "3.6.2"
+github "RxSwiftCommunity/RxOptional" "3.7.0"
 github "adjust/ios_sdk" "v4.17.2"
-github "apple/swift-protobuf" "1.4.0"
+github "apple/swift-protobuf" "1.5.0"
 github "ashleymills/Reachability.swift" "v4.3.0"
+github "garvankeeley/application-services" "0.27.0.1"
 github "getsentry/sentry-cocoa" "4.1.0"
 github "jrendel/SwiftKeychainWrapper" "3.2.0"
-github "mozilla-mobile/MappaMundi" "203e8e5cec7de355eafdff6809ec15b382d00033"
-github "mozilla-mobile/telemetry-ios" "v1.1.0"
-github "mozilla/application-services" "v0.22.1"
+github "mozilla-mobile/MappaMundi" "03f0783269c86e0dbd3a2471c6a37c9bf8aaa64e"
+github "mozilla-mobile/telemetry-ios" "1.1.1"

docs/install.md

@@ -1,4 +1,4 @@
-1. Install Xcode version 10.1
+1. Install Xcode version 10.2
 
 2. Install the latest [Xcode developer tools](https://developer.apple.com/xcode/downloads/) from Apple
 

docs/updating_libraries.md

@@ -1,6 +1,6 @@
 # External Dependencies
 
-With the addition of the Credential Provider API in iOS 12, you will need to use **Xcode 10.1** and **Swift 4.2.1** (`swiftlang-1000.0.36 clang-1000.10.44`) to work on Lockbox.
+With the addition of the Credential Provider API in iOS 12, you will need to use **Xcode 10.2** and **Swift 4.2.1** (`swiftlang-1000.0.36 clang-1000.10.44`) to work on Lockbox.
 
 And if you are running the beta, and haven't already: `sudo xcode-select --switch` to point to the beta Xcode app
 

lockbox-iosTests/SettingListViewSpec.swift

@@ -178,7 +178,7 @@ class SettingListViewSpec: QuickSpec {
                     .disposed(by: self.disposeBag)
 
                 let doneButton = self.subject.navigationItem.rightBarButtonItem!
-                _ = doneButton.target?.perform(doneButton.action)
+                _ = doneButton.target?.perform(doneButton.action, with: nil)
             }
 
             it("tells observers about button taps") {